How to use the new Simple Theme Tutor Plugin

[samuel]

@kshitij

I’m not sure what you mean by external repo? External repo for what?

External, as in the opposite to inline themes as documented at opencraft / dev / tutor-contrib-grove · GitLab :

GROVE_THEMES:
  core:
    size.border.radius.base: 0
    size.border.radius.lg: 0
    size.border.radius.sm: 0

Essentially my question is, in Grove + tutor-contrib-grove, how do I say “use branch X of GitHub - open-craft/edx-simple-theme” for theming? How does the GROVE_THEMES variable with inline design token rules interact with that?

@kshitij

In which case you can set the GROVE_SIMPLE_THEME_REPO variable and GROVE_SIMPLE_THEME_BRANCH for the branch.

This sounds like what we need, but can this be documented please?

@kshitij

The values are not ignored, they should work as always until we switch away from grove,

What do you mean by “work” though? What uses these variables now in grove, if the comprehensive theming is no longer being used since ulmo?

@kshitij

Whatever theme variables/overrides etc are needed for edx-platform need to be set here.

Likewise, what is actually needed for edx-platform overrides since ulmo?

@kshitij

As for how this can be set using grove/tutor here is an example for a global config: https://gitlab.com/opencraft/client/asu-moe/grove-development/-/blob/main/instances/edxapp-development/config.yml?ref_type=heads#L1593

Just so I understand, the theming part is the MFE_CONFIG[“PARAGON_THEME_URLS”] part and/or the GROVE_PARAGON_THEME_URLS? I’m struggling to understand how this relates to design tokens, the simple-theme repo, or GROVE_THEMES. Could you help clear that up?

Is the idea that we use paragon + the design tokens to build a css sheet. And this css sheet is referenced by the PARAGON_THEME_URLS above? Is there a mechanism in grove / tutor-contrib-grove / simple-theme that builds and configures that css from the provided simple-theme or inline design tokens?

Sorry for so many questions, but I’m just trying to understand how all this fits together and this will be important for the Ulmo upgrade. I think there’s opportunity for improved docs here too.