Cancelling upstream merge request

Discussions - Public
1

We are about to cancel an upstream merge request for Autodesk for multiple reasons that are not worth explaining here but you can find more context here. Most of the time we are merging those merge requests in our common branch before being merged in the upstream repository but in the meantime, we may have started using this feature for another client, so that’s why I am creating this topic to ask client owners if this is the case.

Many months ago, we developed this pull request for Autodesk:

[SE-3248] Add progress_video event to video player

but since it is very tight to Autodesk and after some conversation with OpenEdx, they may not want to merge it, so we are about to close this pull request.

This pull request is about sending events from the video player (xblock) to the backend, every 5% of the watching time. I want to be sure nobody is using this feature for any client before reverting this change from our common branch.

Ticket: SE-3248

1 Like
2

Pinging all the cells just to be sure all clients’ owners are aware of this change. @bebop @serenity @falcon

3

I’m not using it for anything, nor am I aware of any clients who are. Thanks for the ping :slight_smile:

4

I remember having seen the progress_video in Cloudera tracking logs recently while I learnt about them.
An example (without personal information), I had it lying around but it’s from 4 months ago:

{"event": "{\"id\": \"2844faada3ff4c768998f36ec9e8a32e\", \"percentage\": 20, \"duration\": 437, \"code\": \"hls\"}", "session": "a37ac14a67033fb4072…………………", "agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36", "context": {"path": "/event", "course_id": "course-v1:Cloudera+JEP+190125", "org_id": "Cloudera", "user_id": 31…}, "accept_language": "en-US,en;q=0.9", "name": "progress_video", "page": "https://ondemand.cloudera.com/courses/course-v1:Cloudera+JEP+190125/courseware/12a33037a15643399bb4d45882a374f8/32be99dba9964b1fb368a5609016494b/2?activate_block_id=block-v1%3ACloudera%2BJEP%2B190125%2Btype%40video%2Bblock%402844faada3ff4c768998f36ec9e8a32e", "time": "2020-12-20T15:11:43.276111+00:00", "host": "ondemand.cloudera.com", "event_source": "browser", "referer": "https://ondemand.cloudera.com/courses/course-v1:Cloudera+JEP+190125/courseware/12a33037a15643399bb4d45882a374f8/32be99dba9964b1fb368a5609016494b/2?activate_block_id=block-v1%3ACloudera%2BJEP%2B190

I assume they don’t use them anymore. Maybe it was just tested there.

Though it makes the logs verbose, it sounds like an useful feature. A client once requested Campus tracking logs to analyze video interactions, and these extra events could have provided more information.
Campus doesn’t use them; I don’t know of any other client using them.

5

Just to let you know that we are about to merge the revert pull request.

1 Like